(PC-34274)[API] feat: add age 17 to 18 eligibility #16072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 04f9379): https://pc-pro-testing--pr16072-pc-34181-credit-v3-e-6z6833bv.web.app (expires Sun, 02 Feb 2025 08:56:49 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 032d233ee67e1c50d6af12e29c936c7076770eb1 |
Comment on lines
100
to
104
| Extended eligibility means that this function considers a 19 year old eligible as long as the specified datetime | ||
| is contained between the eligibility datetime start and end. |
There was a problem hiding this comment.
Suggested change
| Extended eligibility means that this function considers a 19 year old eligible as long as the specified datetime | |
| is contained between the eligibility datetime start and end. | |
| Extended eligibility means that this function considers a non-eligible user eligible, | |
| as long as they were eligible at the specified datetime | |
| This is summed up as this pseudocode: eligibility_start < specified_datetime < eligibility_end |
There was a problem hiding this comment.
Tentative de clarification du commentaire :)
dnguyen1-pass
force-pushed
the
PC-34181-credit-v3-eligibility
branch
4 times, most recently
from
6fbaf8a to
e3ccbee
Compare
cnormant-pass
approved these changes
Jan 30, 2025
dnguyen1-pass
force-pushed
the
PC-34181-credit-v3-eligibility
branch
3 times, most recently
from
cb177e3 to
445e3b7
Compare
dnguyen1-pass
had a problem deploying
to
pullrequest
GitHub Actions
Failure
dnguyen1-pass
force-pushed
the
PC-34181-credit-v3-eligibility
branch
from
445e3b7 to
04f9379
Compare
dnguyen1-pass
had a problem deploying
to
pullrequest
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But de la pull request
Ticket Jira (ou description si BSR) : https://passculture.atlassian.net/browse/PC-34274